Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add array field type test cases #616

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add array field type test cases #616

merged 1 commit into from
Nov 10, 2023

Conversation

ThreadDao
Copy link
Contributor

  • Add array test cases
  • Add some array column or rows data util generation func
  • Optimize row data generation

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 November 8, 2023 08:59
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 8, 2023
@ThreadDao ThreadDao force-pushed the array branch 4 times, most recently from 9b5b561 to f324807 Compare November 10, 2023 04:08
@mergify mergify bot added ci-passed auto merge needed label test/ci intergration test labels Nov 10, 2023
congqixia
congqixia approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 10, 2023
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, ThreadDao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the approved review approved label Nov 10, 2023
@sre-ci-robot sre-ci-robot merged commit b61b0b6 into milvus-io:master Nov 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@yah01 yah01 Awaiting requested review from yah01

Assignees

@congqixia congqixia

Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/XXL Denotes a PR that changes 1000+ lines. test/ci intergration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThreadDao @sre-ci-robot @congqixia